Bug 145713

Summary:

[WK2] Do not indicate Media Keys are present when they are not

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Media

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, eric.carlson, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	dino: review+

Description Brent Fulgham 2015-06-05 14:16:47 PDT

The WK2 WebsiteDataStore::removeData method was missing some content. This fixes the omission.

Comment 1 Brent Fulgham 2015-06-05 14:19:17 PDT

Created attachment 254384 [details]
Patch

Comment 2 Brent Fulgham 2015-06-05 14:20:08 PDT

<rdar://problem/19752566>

Comment 3 Brent Fulgham 2015-06-10 12:10:33 PDT

Created attachment 254668 [details]
Patch

Comment 4 Brent Fulgham 2015-06-10 12:11:37 PDT

It looks like the underlying problem was that the folder holding the Media Keys was getting left behind if a ".DS_Store" file was present (e.g., if you navigated to the folder with the Finder).

We should only report a Media Key exists if the actual file is present.

Comment 5 Dean Jackson 2015-06-10 13:46:50 PDT

Comment on attachment 254668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254668&action=review

> Source/WebKit2/ChangeLog:10
> +        media key file, not just a the directory. Sometimes the directory will exist

typo: "just the"

Comment 6 Brent Fulgham 2015-06-10 13:47:46 PDT

Committed r185428: <http://trac.webkit.org/changeset/185428>

Comment 7 Brent Fulgham 2015-06-10 13:47:57 PDT

(In reply to comment #5)
> Comment on attachment 254668 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254668&action=review
> 
> > Source/WebKit2/ChangeLog:10
> > +        media key file, not just a the directory. Sometimes the directory will exist
> 
> typo: "just the"

Grrr! Thank you for catching that.