Bug 145713 - [WK2] Do not indicate Media Keys are present when they are not
Summary: [WK2] Do not indicate Media Keys are present when they are not
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-05 14:16 PDT by Brent Fulgham
Modified: 2015-06-10 13:47 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2015-06-05 14:19 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2015-06-10 12:10 PDT, Brent Fulgham 		dino: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-06-05 14:16:47 PDT 
The WK2 WebsiteDataStore::removeData method was missing some content. This fixes the omission.
Comment 1 Brent Fulgham 2015-06-05 14:19:17 PDT 
Created attachment 254384 [details]
Patch
Comment 2 Brent Fulgham 2015-06-05 14:20:08 PDT 
<rdar://problem/19752566>
Comment 3 Brent Fulgham 2015-06-10 12:10:33 PDT 
Created attachment 254668 [details]
Patch
Comment 4 Brent Fulgham 2015-06-10 12:11:37 PDT 
It looks like the underlying problem was that the folder holding the Media Keys was getting left behind if a ".DS_Store" file was present (e.g., if you navigated to the folder with the Finder).

We should only report a Media Key exists if the actual file is present.
Comment 5 Dean Jackson 2015-06-10 13:46:50 PDT 
Comment on attachment 254668 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254668&action=review

> Source/WebKit2/ChangeLog:10
> +        media key file, not just a the directory. Sometimes the directory will exist

typo: "just the"
Comment 6 Brent Fulgham 2015-06-10 13:47:46 PDT 
Committed r185428: <http://trac.webkit.org/changeset/185428>
Comment 7 Brent Fulgham 2015-06-10 13:47:57 PDT 
(In reply to comment #5)
> Comment on attachment 254668 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=254668&action=review
> 
> > Source/WebKit2/ChangeLog:10
> > +        media key file, not just a the directory. Sometimes the directory will exist
> 
> typo: "just the"

Grrr! Thank you for catching that.