Bug 145682

Summary: [CMake] Error when gst-plugins-base is missing is too confusing
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: cgarcia, clopez, mcatanzaro, mrobinson, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch cgarcia: review+

Description Michael Catanzaro 2015-06-04 20:26:08 PDT
If gstreamer is installed but gst-plugins-base is not, we get a horrible build error. We should do better than this.

CMake Error: The following variables are used in this project, but they are set to NOTFOUND.
Please set them or make sure they are set and tested correctly in the CMake files:
GSTREAMER_APP_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_AUDIO_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_FFT_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_PBUTILS_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_TAG_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore
GSTREAMER_VIDEO_LIBRARIES (ADVANCED)
    linked by target "WebCore" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK" in directory /home/mcatanzaro/WebKit/Source/WebCore
    linked by target "WebCorePlatformGTK2" in directory /home/mcatanzaro/WebKit/Source/WebCore

-- Configuring incomplete, errors occurred!
See also "/home/mcatanzaro/WebKit/WebKitBuild/Release/CMakeFiles/CMakeOutput.log".
See also "/home/mcatanzaro/WebKit/WebKitBuild/Release/CMakeFiles/CMakeError.log".
Comment 1 Michael Catanzaro 2015-06-11 12:37:08 PDT
*** Bug 145887 has been marked as a duplicate of this bug. ***
Comment 2 Philippe Normand 2015-06-18 07:26:37 PDT
CMake should error out early if, for instance, the gstreamer-video-1.0 pkgconfig file isn't found.
Comment 3 Philippe Normand 2015-06-18 07:39:38 PDT
I'm starting to work on a small (I hope) patch for this.
Comment 4 Philippe Normand 2015-06-18 08:29:10 PDT
Created attachment 255116 [details]
patch
Comment 5 Michael Catanzaro 2015-06-18 09:20:36 PDT
Patch LGTM.
Comment 6 Philippe Normand 2015-06-29 00:52:33 PDT
Hi Carlos, can you please have a look at this patch?
Comment 7 Philippe Normand 2015-06-30 00:19:08 PDT
Committed r186110: <http://trac.webkit.org/changeset/186110>