Summary: | check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Alberto Lopez Perez <clopez> | ||||
Component: | Tools / Tests | Assignee: | Carlos Alberto Lopez Perez <clopez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aestes, bfulgham, commit-queue, ddkilzer, fpizlo, glenn, ysuzuki | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Alberto Lopez Perez
2015-06-04 18:52:52 PDT
Created attachment 254330 [details]
Patch
Comment on attachment 254330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254330&action=review R=me. > Tools/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=145680 This code seems to handle null -> nullptr, but does it really suggest nullptr instead of 0? (In reply to comment #2) > This code seems to handle null -> nullptr, but does it really suggest > nullptr instead of 0? Good point. It only suggest using nullptr instead of NULL (the previous code was suggesting to use 0 instead of NULL) Now is clearer. Committed r185245: <http://trac.webkit.org/changeset/185245> |