Bug 145680 - check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code
Summary: check-webkit-style should recommend using nullptr instead of recommending usi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-04 18:52 PDT by Carlos Alberto Lopez Perez
Modified: 2015-06-05 04:08 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.11 KB, patch)
2015-06-04 19:03 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2015-06-04 18:52:52 PDT 
We should recommend using nullptr instead of 0 or null in C++ code per http://www.webkit.org/coding/coding-style.html#zero-null
Comment 1 Carlos Alberto Lopez Perez 2015-06-04 19:03:07 PDT 
Created attachment 254330 [details]
Patch
Comment 2 Brent Fulgham 2015-06-04 23:22:45 PDT 
Comment on attachment 254330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254330&action=review

R=me.

> Tools/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=145680

This code seems to handle null -> nullptr, but does it really suggest nullptr instead of 0?
Comment 3 Carlos Alberto Lopez Perez 2015-06-05 03:46:18 PDT 
(In reply to comment #2)
> This code seems to handle null -> nullptr, but does it really suggest
> nullptr instead of 0?

Good point.

It only suggest using nullptr instead of NULL (the previous code was suggesting to use 0 instead of NULL)
Comment 4 Carlos Alberto Lopez Perez 2015-06-05 03:59:58 PDT 
Now is clearer.
Comment 5 Carlos Alberto Lopez Perez 2015-06-05 04:07:23 PDT 
Committed r185245: <http://trac.webkit.org/changeset/185245>