RESOLVED FIXED 145680
check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code 
https://bugs.webkit.org/show_bug.cgi?id=145680
Summary check-webkit-style should recommend using nullptr instead of recommending usi...
Carlos Alberto Lopez Perez
Reported 2015-06-04 18:52:52 PDT
We should recommend using nullptr instead of 0 or null in C++ code per http://www.webkit.org/coding/coding-style.html#zero-null
Attachments
Patch (5.11 KB, patch)
2015-06-04 19:03 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Alberto Lopez Perez
Comment 1 2015-06-04 19:03:07 PDT
Created attachment 254330 [details] Patch
Brent Fulgham
Comment 2 2015-06-04 23:22:45 PDT
Comment on attachment 254330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254330&action=review R=me. > Tools/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=145680 This code seems to handle null -> nullptr, but does it really suggest nullptr instead of 0?
Carlos Alberto Lopez Perez
Comment 3 2015-06-05 03:46:18 PDT
(In reply to comment #2) > This code seems to handle null -> nullptr, but does it really suggest > nullptr instead of 0? Good point. It only suggest using nullptr instead of NULL (the previous code was suggesting to use 0 instead of NULL)
Carlos Alberto Lopez Perez
Comment 4 2015-06-05 03:59:58 PDT
Now is clearer.
Carlos Alberto Lopez Perez
Comment 5 2015-06-05 04:07:23 PDT
Committed r185245: <http://trac.webkit.org/changeset/185245>
Note You need to log in before you can comment on or make changes to this bug.