Bug 145668

Summary:

Web Inspector: Fixing code style and adding more limitations for bug 141262

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Devin Rousso

Reported 2015-06-04 15:44:15 PDT

Fixing style changes in https://bugs.webkit.org/show_bug.cgi?id=141262. In addition, code was added to prevent the invalid strikethrough from being applied to the following cases: - <property name>: // Only the property name and colon are present. - <property name>: <property value>; // Multiple/zero spaces are present between the colon and property value (caused the strikethrough to be applied to the wrong selection of text).

Attachments
Patch (4.45 KB, patch) 2015-06-04 15:49 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (4.50 KB, patch) 2015-06-05 15:23 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (4.09 KB, patch) 2015-06-05 17:49 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2015-06-04 15:44:40 PDT

<rdar://problem/21250324>

Devin Rousso

Comment 2 2015-06-04 15:49:00 PDT

Created attachment 254309 [details] Patch

Timothy Hatcher

Comment 3 2015-06-04 21:29:37 PDT

Comment on attachment 254309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254309&action=review > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:538 > + if (!property.valid && propertyNameIsValid && property.text.slice(-1) !== ":") { .trim().endsWith(":")?

Devin Rousso

Comment 4 2015-06-05 15:23:06 PDT

Created attachment 254392 [details] Patch

WebKit Commit Bot

Comment 5 2015-06-05 17:28:20 PDT

Comment on attachment 254392 [details] Patch Rejecting attachment 254392 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 254392, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6439325541597184

Timothy Hatcher

Comment 6 2015-06-05 17:29:28 PDT

Comment on attachment 254392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254392&action=review > Source/WebInspectorUI/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Double ChangeLog.

Devin Rousso

Comment 7 2015-06-05 17:49:49 PDT

Created attachment 254402 [details] Patch

WebKit Commit Bot

Comment 8 2015-06-05 18:23:40 PDT

Comment on attachment 254402 [details] Patch Clearing flags on attachment: 254402 Committed r185282: <http://trac.webkit.org/changeset/185282>

WebKit Commit Bot

Comment 9 2015-06-05 18:23:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.