Summary: | Web Inspector: Fixing code style and adding more limitations for bug 141262 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | DoNotImportToRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Devin Rousso
2015-06-04 15:44:15 PDT
Created attachment 254309 [details]
Patch
Comment on attachment 254309 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254309&action=review > Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.js:538 > + if (!property.valid && propertyNameIsValid && property.text.slice(-1) !== ":") { .trim().endsWith(":")? Created attachment 254392 [details]
Patch
Comment on attachment 254392 [details] Patch Rejecting attachment 254392 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 254392, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebInspectorUI/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/6439325541597184 Comment on attachment 254392 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254392&action=review > Source/WebInspectorUI/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). Double ChangeLog. Created attachment 254402 [details]
Patch
Comment on attachment 254402 [details] Patch Clearing flags on attachment: 254402 Committed r185282: <http://trac.webkit.org/changeset/185282> All reviewed patches have been landed. Closing bug. |