Bug 145634

Summary: [Cocoa] Clean up m_font inside FontPlatformData
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch kling: review+

Description Myles C. Maxfield 2015-06-03 22:57:05 PDT
[Cocoa] Clean up m_font inside FontPlatformData
Comment 1 Myles C. Maxfield 2015-06-03 23:13:39 PDT
Created attachment 254248 [details]
Patch
Comment 2 Myles C. Maxfield 2015-06-03 23:20:46 PDT
Comment on attachment 254248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254248&action=review

> Source/WebCore/platform/graphics/FontPlatformData.h:215
> +    bool m_isHashTableDeletedValue { false };

If I move this bool down to the rest of them, we get it for free!
Comment 3 Andreas Kling 2015-06-04 08:51:30 PDT
Comment on attachment 254248 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254248&action=review

Oh wow, this is so much nicer. r=me

>> Source/WebCore/platform/graphics/FontPlatformData.h:215
>> +    bool m_isHashTableDeletedValue { false };
> 
> If I move this bool down to the rest of them, we get it for free!

So let's do that too :)
Comment 4 Myles C. Maxfield 2015-06-04 09:51:04 PDT
Committed r185200: <http://trac.webkit.org/changeset/185200>