Bug 145591

Summary: Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-06-02 21:43:32 PDT
* SUMMARY Sidebar and sometimes ContentView scroll position is lost when switching between tabs. * STEPS TO REPRODUCE 1. Inspect <http://apple.com> 2. Show Resources Tab 3. Scroll Resources list to the bottom 4. Switch to Elements tab 5. Switch back to Resources tab => Expected Resources list to be scrolled to the bottom * NOTES - Repeat with Timeline panel (sidebar / content view are linked) - Repeat with Details sidebars (non-DOM details sidebar panels, DOM details sidebar panels have their own refresh issues)
Attachments
[PATCH] Proposed Fix (6.13 KB, patch)
2015-06-02 21:53 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-06-02 21:43:52 PDT
<rdar://problem/21176592>
Joseph Pecoraro
Comment 2 2015-06-02 21:53:20 PDT
Created attachment 254144 [details] [PATCH] Proposed Fix
Timothy Hatcher
Comment 3 2015-06-02 21:57:19 PDT
Comment on attachment 254144 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=254144&action=review > Source/WebInspectorUI/ChangeLog:3 > + Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs How does this fix content view scroll position? I only see sidebar code being changed.
WebKit Commit Bot
Comment 4 2015-06-02 22:47:20 PDT
Comment on attachment 254144 [details] [PATCH] Proposed Fix Clearing flags on attachment: 254144 Committed r185141: <http://trac.webkit.org/changeset/185141>
WebKit Commit Bot
Comment 5 2015-06-02 22:47:24 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2015-06-03 12:19:58 PDT
(In reply to comment #3) > Comment on attachment 254144 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254144&action=review > > > Source/WebInspectorUI/ChangeLog:3 > > + Web Inspector: Sidebar and sometimes ContentView scroll position is lost when switching between tabs > > How does this fix content view scroll position? I only see sidebar code > being changed. In Timelines the sidebar / content view are linked. So scrolling the sidebar just made everything work.
Note You need to log in before you can comment on or make changes to this bug.