| Summary: | AX: Expose field sets to accessibility clients | ||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Greg Hughes <ghughes> | ||||||||||||||||||||
| Component: | Accessibility | Assignee: | Greg Hughes <ghughes> | ||||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||||
| Severity: | Normal | CC: | aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, rniwa, samuel_white, webkit-bug-importer | ||||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||||
| OS: | OS X 10.10 | ||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||
|
Description
Greg Hughes
2015-06-02 18:05:38 PDT
Created attachment 254208 [details]
Patch
Comment on attachment 254208 [details]
Patch
Bug fixes like this one need to come with a regression test. Please add one and post the combined patch for review.
Comment on attachment 254208 [details] Patch Attachment 254208 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5945873527734272 New failing tests: accessibility/roles-exposed.html Created attachment 254214 [details]
Archive of layout-test-results from ews101 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 254208 [details] Patch Attachment 254208 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5502661356945408 New failing tests: accessibility/roles-exposed.html Created attachment 254215 [details]
Archive of layout-test-results from ews107 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 254220 [details]
Patch
Comment on attachment 254220 [details] Patch Attachment 254220 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6650975758581760 New failing tests: accessibility/roles-exposed.html Created attachment 254221 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 254220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254220&action=review check the other platform directories for this test result (mac-wk2, mac-mavericks, etc) > Source/WebCore/ChangeLog:6 > + Expose fieldsets to the accessibility API via a subrole of AXFieldset this sentence should end in a period Created attachment 254225 [details]
Patch
Created attachment 254226 [details]
Patch
Comment on attachment 254226 [details] Patch Attachment 254226 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6497599120998400 New failing tests: accessibility/roles-exposed.html Created attachment 254230 [details]
Archive of layout-test-results from ews102 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Created attachment 254231 [details]
Patch
Comment on attachment 254231 [details] Patch Clearing flags on attachment: 254231 Committed r185185: <http://trac.webkit.org/changeset/185185> All reviewed patches have been landed. Closing bug. |