RESOLVED FIXED 145585
AX: Expose field sets to accessibility clients 
https://bugs.webkit.org/show_bug.cgi?id=145585
Summary AX: Expose field sets to accessibility clients
Greg Hughes
Reported 2015-06-02 18:05:38 PDT
Fieldsets are structurally very important elements because they provide contextual information for sub-elements. Fieldsets are exposed as AXGroup roles. Their subrole should indicate that the group provides contextual information for sub-elements.
Attachments
Patch (1.39 KB, patch)
2015-06-03 14:25 PDT, Greg Hughes 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-mavericks (535.31 KB, application/zip)
2015-06-03 15:14 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-mavericks-wk2 (565.86 KB, application/zip)
2015-06-03 15:20 PDT, Build Bot 		no flags
Details
Patch (2.52 KB, patch)
2015-06-03 17:20 PDT, Greg Hughes 		cfleizach: review-
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-mavericks (605.34 KB, application/zip)
2015-06-03 17:33 PDT, Build Bot 		no flags
Details
Patch (3.12 KB, application/octet-stream)
2015-06-03 17:57 PDT, Greg Hughes 		no flags
Details
Patch (3.12 KB, patch)
2015-06-03 17:57 PDT, Greg Hughes 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-mavericks (535.26 KB, application/zip)
2015-06-03 18:30 PDT, Build Bot 		no flags
Details
Patch (2.99 KB, patch)
2015-06-03 18:34 PDT, Greg Hughes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-06-02 18:06:30 PDT
<rdar://problem/21213609>
Greg Hughes
Comment 2 2015-06-03 14:25:34 PDT
Created attachment 254208 [details] Patch
Darin Adler
Comment 3 2015-06-03 14:26:20 PDT
Comment on attachment 254208 [details] Patch Bug fixes like this one need to come with a regression test. Please add one and post the combined patch for review.
Build Bot
Comment 4 2015-06-03 15:14:51 PDT
Comment on attachment 254208 [details] Patch Attachment 254208 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5945873527734272 New failing tests: accessibility/roles-exposed.html
Build Bot
Comment 5 2015-06-03 15:14:55 PDT
Created attachment 254214 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Build Bot
Comment 6 2015-06-03 15:20:16 PDT
Comment on attachment 254208 [details] Patch Attachment 254208 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5502661356945408 New failing tests: accessibility/roles-exposed.html
Build Bot
Comment 7 2015-06-03 15:20:19 PDT
Created attachment 254215 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Greg Hughes
Comment 8 2015-06-03 17:20:23 PDT
Created attachment 254220 [details] Patch
Build Bot
Comment 9 2015-06-03 17:33:45 PDT
Comment on attachment 254220 [details] Patch Attachment 254220 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6650975758581760 New failing tests: accessibility/roles-exposed.html
Build Bot
Comment 10 2015-06-03 17:33:49 PDT
Created attachment 254221 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
chris fleizach
Comment 11 2015-06-03 17:38:56 PDT
Comment on attachment 254220 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254220&action=review check the other platform directories for this test result (mac-wk2, mac-mavericks, etc) > Source/WebCore/ChangeLog:6 > + Expose fieldsets to the accessibility API via a subrole of AXFieldset this sentence should end in a period
Greg Hughes
Comment 12 2015-06-03 17:57:11 PDT
Created attachment 254225 [details] Patch
Greg Hughes
Comment 13 2015-06-03 17:57:39 PDT
Created attachment 254226 [details] Patch
Build Bot
Comment 14 2015-06-03 18:30:51 PDT
Comment on attachment 254226 [details] Patch Attachment 254226 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6497599120998400 New failing tests: accessibility/roles-exposed.html
Build Bot
Comment 15 2015-06-03 18:30:58 PDT
Created attachment 254230 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Greg Hughes
Comment 16 2015-06-03 18:34:38 PDT
Created attachment 254231 [details] Patch
WebKit Commit Bot
Comment 17 2015-06-03 21:20:18 PDT
Comment on attachment 254231 [details] Patch Clearing flags on attachment: 254231 Committed r185185: <http://trac.webkit.org/changeset/185185>
WebKit Commit Bot
Comment 18 2015-06-03 21:20:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.