Bug 145578

Summary: Improve test coverage for changes made in 145527
Product: WebKit Reporter: Michael Saboff <msaboff>
Component: JavaScriptCoreAssignee: Michael Saboff <msaboff>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 145527    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Michael Saboff
Reported 2015-06-02 16:33:29 PDT
When the fix for https://bugs.webkit.org/show_bug.cgi?id=145527 was being prepared, it was believed that the bug involved a race between the main thread GC'ing and a worker thread compiling a DFG replacement for a baseline function. Testing for such a case in a deterministic was considered not worth it. We should make sure that there is test coverage for most / all of the new paths added.
Attachments
Patch (3.37 KB, patch)
2015-06-02 16:43 PDT, Michael Saboff 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Saboff
Comment 1 2015-06-02 16:43:42 PDT
Created attachment 254122 [details] Patch
Geoffrey Garen
Comment 2 2015-06-03 10:59:40 PDT
Comment on attachment 254122 [details] Patch r=me
WebKit Commit Bot
Comment 3 2015-06-03 11:49:06 PDT
Comment on attachment 254122 [details] Patch Clearing flags on attachment: 254122 Committed r185158: <http://trac.webkit.org/changeset/185158>
WebKit Commit Bot
Comment 4 2015-06-03 11:49:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.