Bug 145577

Summary: [CoordinatedGraphics] Refactor TiledBackingStoreClient
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit EFLAssignee: Ryuan Choi <ryuan.choi>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue, kondapallykalyan, lucas.de.marchi, luiz, noam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Ryuan Choi
Reported 2015-06-02 16:17:56 PDT
TiledBackingStoreClient has some unnecessary virtual methods.
Attachments
Patch (10.81 KB, patch)
2015-06-02 16:23 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2015-06-02 16:23:18 PDT
Created attachment 254121 [details] Patch
Gyuyoung Kim
Comment 2 2015-06-02 18:51:39 PDT
Comment on attachment 254121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254121&action=review LGTM. However it would be nicer if you write description more detailed as I comment. > Source/WebCore/ChangeLog:13 > + (WebCore::CoordinatedGraphicsLayer::didUpdateTileBuffers): Please add "Added" for didUpdateTileBuffers(). > Source/WebCore/ChangeLog:16 > + (WebCore::CoordinatedGraphicsLayer::tiledBackingStoreBackgroundColor): Deleted. It would be good if you write that "tiledBackingStoreBackgroundColor() is not used anywhere." > Source/WebCore/ChangeLog:19 > + (WebCore::CoordinatedTile::updateBackBuffer): Please write what is changed and why do you modify.
Ryuan Choi
Comment 3 2015-06-02 20:39:55 PDT
Committed r185140: <http://trac.webkit.org/changeset/185140>
Ryuan Choi
Comment 4 2015-06-02 20:40:49 PDT
Comment on attachment 254121 [details] Patch clearing flags. Thanks, I added more commentes and landed manually.
Note You need to log in before you can comment on or make changes to this bug.