| Summary: | [CoordinatedGraphics] Refactor TiledBackingStoreClient | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ryuan Choi <ryuan.choi> | ||||
| Component: | WebKit EFL | Assignee: | Ryuan Choi <ryuan.choi> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cmarcelo, commit-queue, kondapallykalyan, lucas.de.marchi, luiz, noam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Ryuan Choi
2015-06-02 16:17:56 PDT
Created attachment 254121 [details]
Patch
Comment on attachment 254121 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254121&action=review LGTM. However it would be nicer if you write description more detailed as I comment. > Source/WebCore/ChangeLog:13 > + (WebCore::CoordinatedGraphicsLayer::didUpdateTileBuffers): Please add "Added" for didUpdateTileBuffers(). > Source/WebCore/ChangeLog:16 > + (WebCore::CoordinatedGraphicsLayer::tiledBackingStoreBackgroundColor): Deleted. It would be good if you write that "tiledBackingStoreBackgroundColor() is not used anywhere." > Source/WebCore/ChangeLog:19 > + (WebCore::CoordinatedTile::updateBackBuffer): Please write what is changed and why do you modify. Committed r185140: <http://trac.webkit.org/changeset/185140> Comment on attachment 254121 [details]
Patch
clearing flags.
Thanks, I added more commentes and landed manually.
|