Bug 145577 - [CoordinatedGraphics] Refactor TiledBackingStoreClient
Summary: [CoordinatedGraphics] Refactor TiledBackingStoreClient
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-02 16:17 PDT by Ryuan Choi
Modified: 2015-06-02 20:40 PDT (History)
6 users (show)

See Also:


Attachments
Patch (10.81 KB, patch)
2015-06-02 16:23 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2015-06-02 16:17:56 PDT
TiledBackingStoreClient has some unnecessary virtual methods.
Comment 1 Ryuan Choi 2015-06-02 16:23:18 PDT
Created attachment 254121 [details]
Patch
Comment 2 Gyuyoung Kim 2015-06-02 18:51:39 PDT
Comment on attachment 254121 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254121&action=review

LGTM. However it would be nicer if you write description more detailed as I comment.

> Source/WebCore/ChangeLog:13
> +        (WebCore::CoordinatedGraphicsLayer::didUpdateTileBuffers):

Please add "Added" for didUpdateTileBuffers().

> Source/WebCore/ChangeLog:16
> +        (WebCore::CoordinatedGraphicsLayer::tiledBackingStoreBackgroundColor): Deleted.

It would be good if you write that "tiledBackingStoreBackgroundColor() is not used anywhere."

> Source/WebCore/ChangeLog:19
> +        (WebCore::CoordinatedTile::updateBackBuffer):

Please write what is changed and why do you modify.
Comment 3 Ryuan Choi 2015-06-02 20:39:55 PDT
Committed r185140: <http://trac.webkit.org/changeset/185140>
Comment 4 Ryuan Choi 2015-06-02 20:40:49 PDT
Comment on attachment 254121 [details]
Patch

clearing flags.

Thanks, I added more commentes and landed manually.