MediaSessions should keep track of their current state

• Component: Media
• Status: RESOLVED FIXED

[Matt Rajca]

Per the Media Session spec, each Media Session has a current state, which is 'Idle' at the time of construction.

[Radar WebKit Bug Importer]

<rdar://problem/21210114>

[Matt Rajca]

Created attachment 254113 [details]
Patch

[Conrad Shultz]

Comment on attachment 254113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254113&action=review

> Source/WebCore/Modules/mediasession/MediaSession.h:55
> +    };

Will this state eventually be exposed publicly? If so, should this start out outside the private section?

[Matt Rajca]

Comment on attachment 254113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254113&action=review

>> Source/WebCore/Modules/mediasession/MediaSession.h:55
>> +    };
> 
> Will this state eventually be exposed publicly? If so, should this start out outside the private section?

This state is not exposed in the MediaSession IDL "interface" file, so we should keep it private until we actually need to access it outside of the Media Session itself.

[Alex Christensen]

Comment on attachment 254113 [details]
Patch

This is good, but I think it should be included with some changes that actually use it.

[WebKit Commit Bot]

Comment on attachment 254113 [details]
Patch

Clearing flags on attachment: 254113

Committed r185136: <http://trac.webkit.org/changeset/185136>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.