Bug 145575 - MediaSessions should keep track of their current state
Summary: MediaSessions should keep track of their current state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 145411
  Show dependency treegraph
 
Reported: 2015-06-02 15:18 PDT by Matt Rajca
Modified: 2015-06-02 17:45 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.34 KB, patch)
2015-06-02 15:33 PDT, Matt Rajca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2015-06-02 15:18:48 PDT
Per the Media Session spec, each Media Session has a current state, which is 'Idle' at the time of construction.
Comment 1 Radar WebKit Bug Importer 2015-06-02 15:19:28 PDT
<rdar://problem/21210114>
Comment 2 Matt Rajca 2015-06-02 15:33:19 PDT
Created attachment 254113 [details]
Patch
Comment 3 Conrad Shultz 2015-06-02 15:41:39 PDT
Comment on attachment 254113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254113&action=review

> Source/WebCore/Modules/mediasession/MediaSession.h:55
> +    };

Will this state eventually be exposed publicly? If so, should this start out outside the private section?
Comment 4 Matt Rajca 2015-06-02 15:44:21 PDT
Comment on attachment 254113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254113&action=review

>> Source/WebCore/Modules/mediasession/MediaSession.h:55
>> +    };
> 
> Will this state eventually be exposed publicly? If so, should this start out outside the private section?

This state is not exposed in the MediaSession IDL "interface" file, so we should keep it private until we actually need to access it outside of the Media Session itself.
Comment 5 Alex Christensen 2015-06-02 16:03:19 PDT
Comment on attachment 254113 [details]
Patch

This is good, but I think it should be included with some changes that actually use it.
Comment 6 WebKit Commit Bot 2015-06-02 17:45:25 PDT
Comment on attachment 254113 [details]
Patch

Clearing flags on attachment: 254113

Committed r185136: <http://trac.webkit.org/changeset/185136>
Comment 7 WebKit Commit Bot 2015-06-02 17:45:29 PDT
All reviewed patches have been landed.  Closing bug.