Bug 145559

Summary:

[Mac] occasional crash in Document::playbackTargetAvailabilityDidChange

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, commit-queue, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	none

Description Eric Carlson 2015-06-02 12:18:25 PDT

media/track/media-element-enqueue-event-crash.html sometimes crashes in Document::playbackTargetAvailabilityDidChange when GuardMalloc is enabled.

Comment 1 Eric Carlson 2015-06-02 12:18:52 PDT

rdar://problem/21106044

Comment 2 Eric Carlson 2015-06-02 12:44:30 PDT

Created attachment 254082 [details]
Proposed patch.

Comment 3 WebKit Commit Bot 2015-06-02 12:46:48 PDT

Attachment 254082 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaElementSession.h:47:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/MediaElementSession.h:48:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Darin Adler 2015-06-02 13:37:09 PDT

Comment on attachment 254082 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=254082&action=review

> Source/WebCore/html/MediaElementSession.h:48
> +    void registerWithDocument(Document& document);
> +    void unregisterWithDocument(Document& document);

Argument names don’t add anything here.

Comment 5 Eric Carlson 2015-06-02 14:05:59 PDT

Committed r185120: https://trac.webkit.org/r185120