Bug 145559

Summary: [Mac] occasional crash in Document::playbackTargetAvailabilityDidChange
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2015-06-02 12:18:25 PDT
media/track/media-element-enqueue-event-crash.html sometimes crashes in Document::playbackTargetAvailabilityDidChange when GuardMalloc is enabled.
Attachments
Proposed patch. (4.66 KB, patch)
2015-06-02 12:44 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2015-06-02 12:18:52 PDT
rdar://problem/21106044
Eric Carlson
Comment 2 2015-06-02 12:44:30 PDT
Created attachment 254082 [details] Proposed patch.
WebKit Commit Bot
Comment 3 2015-06-02 12:46:48 PDT
Attachment 254082 [details] did not pass style-queue: ERROR: Source/WebCore/html/MediaElementSession.h:47: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebCore/html/MediaElementSession.h:48: The parameter name "document" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 4 2015-06-02 13:37:09 PDT
Comment on attachment 254082 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=254082&action=review > Source/WebCore/html/MediaElementSession.h:48 > + void registerWithDocument(Document& document); > + void unregisterWithDocument(Document& document); Argument names don’t add anything here.
Eric Carlson
Comment 5 2015-06-02 14:05:59 PDT
Committed r185120: https://trac.webkit.org/r185120
Note You need to log in before you can comment on or make changes to this bug.