Bug 145559 - [Mac] occasional crash in Document::playbackTargetAvailabilityDidChange
Summary: [Mac] occasional crash in Document::playbackTargetAvailabilityDidChange
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-02 12:18 PDT by Eric Carlson
Modified: 2015-06-03 09:16 PDT (History)
3 users (show)

See Also:

Attachments
Proposed patch. (4.66 KB, patch)
2015-06-02 12:44 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2015-06-02 12:18:25 PDT 
media/track/media-element-enqueue-event-crash.html sometimes crashes in Document::playbackTargetAvailabilityDidChange when GuardMalloc is enabled.
Comment 1 Eric Carlson 2015-06-02 12:18:52 PDT 
rdar://problem/21106044
Comment 2 Eric Carlson 2015-06-02 12:44:30 PDT 
Created attachment 254082 [details]
Proposed patch.
Comment 3 WebKit Commit Bot 2015-06-02 12:46:48 PDT 
Attachment 254082 [details] did not pass style-queue:


ERROR: Source/WebCore/html/MediaElementSession.h:47:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/html/MediaElementSession.h:48:  The parameter name "document" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Darin Adler 2015-06-02 13:37:09 PDT 
Comment on attachment 254082 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=254082&action=review

> Source/WebCore/html/MediaElementSession.h:48
> +    void registerWithDocument(Document& document);
> +    void unregisterWithDocument(Document& document);

Argument names don’t add anything here.
Comment 5 Eric Carlson 2015-06-02 14:05:59 PDT 
Committed r185120: https://trac.webkit.org/r185120