Bug 145548

Summary: Web Inspector: Better handle keyboard events in the quick console prompt
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2015-06-01 21:37:16 PDT
* SUMMARY Better handle keyboard events in the quick console prompt. * NOTES - Cmd+F in the quick console doesn't behave as expected if the LogContentView is not showing - Cmd+S in the quick console doesn't trigger save dialog even if in the Console Tab We should better handle the different situations you have keyboard shortcuts while in the quick console prompt.
Attachments
[PATCH] Proposed Fix (7.40 KB, patch)
2015-06-01 21:42 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2015-06-01 21:42:15 PDT
Created attachment 254049 [details] [PATCH] Proposed Fix Note, LogContentView currently always makes this.prompt === WebInspector.quickConsole.prompt. If that changes, we wouldn't want to just blatantly check if WebInspector.isSplitConsole.
WebKit Commit Bot
Comment 2 2015-06-01 22:46:47 PDT
Comment on attachment 254049 [details] [PATCH] Proposed Fix Clearing flags on attachment: 254049 Committed r185104: <http://trac.webkit.org/changeset/185104>
WebKit Commit Bot
Comment 3 2015-06-01 22:46:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.