Bug 145548 - Web Inspector: Better handle keyboard events in the quick console prompt
Summary: Web Inspector: Better handle keyboard events in the quick console prompt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2015-06-01 21:37 PDT by Joseph Pecoraro
Modified: 2015-06-01 22:46 PDT (History)
9 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (7.40 KB, patch)
2015-06-01 21:42 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-06-01 21:37:16 PDT 
* SUMMARY
Better handle keyboard events in the quick console prompt.

* NOTES
- Cmd+F in the quick console doesn't behave as expected if the LogContentView is not showing
- Cmd+S in the quick console doesn't trigger save dialog even if in the Console Tab

We should better handle the different situations you have keyboard shortcuts while in the quick console prompt.
Comment 1 Joseph Pecoraro 2015-06-01 21:42:15 PDT 
Created attachment 254049 [details]
[PATCH] Proposed Fix

Note, LogContentView currently always makes this.prompt === WebInspector.quickConsole.prompt. If that changes, we wouldn't want to just blatantly check if WebInspector.isSplitConsole.
Comment 2 WebKit Commit Bot 2015-06-01 22:46:47 PDT 
Comment on attachment 254049 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 254049

Committed r185104: <http://trac.webkit.org/changeset/185104>
Comment 3 WebKit Commit Bot 2015-06-01 22:46:50 PDT 
All reviewed patches have been landed.  Closing bug.