Summary: | Crash in com.apple.WebKit.WebContent at com.apple.JavaScriptCore: JSC::revertCall + 24 | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michael Saboff <msaboff> | ||||
Component: | JavaScriptCore | Assignee: | Michael Saboff <msaboff> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P2 | ||||||
Version: | 312.x | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 145578 | ||||||
Attachments: |
|
Description
Michael Saboff
2015-06-01 15:02:38 PDT
Created attachment 254016 [details]
Patch
Comment on attachment 254016 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254016&action=review > Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp:116 > + for (Bag<PolymorphicCallNode>::iterator iter = m_callNodes.begin(); !!iter; ++iter) { > + PolymorphicCallNode& node = **iter; > + if (node.hasCallLinkInfo(info)) > + node.clearCallLinkInfo(); > + } All of the nodes for a stub routine should have the same CallLinkInfo. I agree that being conservative is great, but maybe you could add a comment that you're just being paranoid. (In reply to comment #3) > Comment on attachment 254016 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=254016&action=review > > > Source/JavaScriptCore/jit/PolymorphicCallStubRoutine.cpp:116 > > + for (Bag<PolymorphicCallNode>::iterator iter = m_callNodes.begin(); !!iter; ++iter) { > > + PolymorphicCallNode& node = **iter; > > + if (node.hasCallLinkInfo(info)) > > + node.clearCallLinkInfo(); > > + } > > All of the nodes for a stub routine should have the same CallLinkInfo. I > agree that being conservative is great, but maybe you could add a comment > that you're just being paranoid. I'll add such a comment. Committed r185084: <http://trac.webkit.org/changeset/185084> |