Bug 145524

Summary: Add the ability to tell between Catch and Finally blocks
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, keith_miller, mmirman, msaboff, saam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 145525    
Attachments:
Description Flags
the patch.
msaboff: review+
Patch for landing (already r+'ed by Michael). none

Description Mark Lam 2015-06-01 13:55:34 PDT 
... and also SynthesizedFinally blocks.
Comment 1 Mark Lam 2015-06-01 15:44:55 PDT 
Created attachment 254019 [details]
the patch.
Comment 2 WebKit Commit Bot 2015-06-01 15:48:05 PDT 
Attachment 254019 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:64:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:65:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Lam 2015-06-01 15:50:19 PDT 
(In reply to comment #2)
> ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:64:  Please declare enum
> bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
> ERROR: Source/JavaScriptCore/bytecode/HandlerInfo.h:65:  Please declare enum
> bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
> Total errors found: 2 in 6 files

The style checker is mistaken.  I'm already using an unsigned integral type (uint32_t).
Comment 4 Michael Saboff 2015-06-01 16:08:04 PDT 
Comment on attachment 254019 [details]
the patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=254019&action=review

Continue to use the name popTryAndEmitCatch() as it emits an op_catch bytecode.
r=me

> Source/JavaScriptCore/ChangeLog:8
> +        ... and also SynthesizedFinally blocks too.

Add what you mean by "SynthesizedFinally".
Comment 5 Mark Lam 2015-06-01 16:20:01 PDT 
Created attachment 254021 [details]
Patch for landing (already r+'ed by Michael).
Comment 6 Mark Lam 2015-06-01 16:23:33 PDT 
Thanks for the review.  Landed in r185083: <http://trac.webkit.org/r185083>.