Bug 145511

Summary: Fix the webkitpy scm unittests after r174051
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, glenn, mcatanzaro, mmaxfield, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 137166, 143967    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-06-01 05:46:06 PDT
http://trac.webkit.org/changeset/174051 broke the SCM tests ( Tools/Scripts/test-webkitpy -a ) [119/1563] webkitpy.common.checkout.scm.scm_unittest.GitTestWithMock.test_create_patch erred: Traceback (most recent call last): File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1569, in test_create_patch scm = self.make_scm(logging_executive=True) File "/home/webkit/WebKit/Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py", line 1563, in make_scm scm = Git(cwd=".", executive=MockExecutive(), filesystem=MockFileSystem()) TypeError: __init__() takes exactly 3 arguments (2 given) ... r174051 added one more argument to Git.__init__ , but didn't add it to the unittest.
Attachments
Patch (1.63 KB, patch)
2015-06-01 05:47 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-06-01 05:47:37 PDT
Created attachment 253995 [details] Patch
WebKit Commit Bot
Comment 2 2015-06-01 11:00:28 PDT
Comment on attachment 253995 [details] Patch Clearing flags on attachment: 253995 Committed r185064: <http://trac.webkit.org/changeset/185064>
WebKit Commit Bot
Comment 3 2015-06-01 11:00:33 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 4 2015-06-01 11:45:20 PDT
Were those the only failures you're seeing? I reported a bunch of failures in bug #143967; maybe the others have been fixed somehow.
Csaba Osztrogonác
Comment 5 2015-07-08 05:07:58 PDT
(In reply to comment #4) > Were those the only failures you're seeing? I reported a bunch of failures > in bug #143967; maybe the others have been fixed somehow. Yes, I have no failure now on Ubuntu 14.04.
Note You need to log in before you can comment on or make changes to this bug.