Bug 145510

Summary: Fix the !ENABLE(VIDEO_TRACK) build after r184799
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: New BugsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jer.noble, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 145228    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2015-06-01 04:39:58 PDT
http://trac.webkit.org/changeset/184799 broke the !ENABLE(VIDEO_TRACK) build: ../../Source/WebCore/testing/Internals.cpp: In member function 'WTF::Vector<WTF::String> WebCore::Internals::userPreferredAudioCharacteristics() const': ../../Source/WebCore/testing/Internals.cpp:1301:37: error: invalid use of incomplete type 'class WebCore::PageGroup' In file included from ../../Source/WebCore/inspector/InspectorInstrumentation.h:41:0, from ../../Source/WebCore/testing/Internals.cpp:73: ../../Source/WebCore/page/Page.h:92:7: error: forward declaration of 'class WebCore::PageGroup' ../../Source/WebCore/testing/Internals.cpp: In member function 'void WebCore::Internals::setUserPreferredAudioCharacteristic(const WTF::String&)': ../../Source/WebCore/testing/Internals.cpp:1309:30: error: invalid use of incomplete type 'class WebCore::PageGroup' In file included from ../../Source/WebCore/inspector/InspectorInstrumentation.h:41:0, from ../../Source/WebCore/testing/Internals.cpp:73: ../../Source/WebCore/page/Page.h:92:7: error: forward declaration of 'class WebCore::PageGroup' ../../Source/WebCore/testing/Internals.cpp: In member function 'WTF::Vector<WTF::String> WebCore::Internals::userPreferredAudioCharacteristics() const': ../../Source/WebCore/testing/Internals.cpp:1302:1: error: control reaches end of non-void function [-Werror=return-type]
Attachments
Patch (1.87 KB, patch)
2015-06-01 04:41 PDT, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2015-06-01 04:41:14 PDT
Created attachment 253993 [details] Patch
Eric Carlson
Comment 2 2015-06-01 07:41:37 PDT
Comment on attachment 253993 [details] Patch Sorry about that Ossy, and thanks for the fix!
WebKit Commit Bot
Comment 3 2015-06-01 08:29:12 PDT
Comment on attachment 253993 [details] Patch Clearing flags on attachment: 253993 Committed r185058: <http://trac.webkit.org/changeset/185058>
WebKit Commit Bot
Comment 4 2015-06-01 08:29:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.