[Mac] Audio tracks tagged as 'describes-video' are not automatically selected when that system accessibility option is set.
Created attachment 253472 [details] Patch
Comment on attachment 253472 [details] Patch Attachment 253472 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4800623719481344 Number of test failures exceeded the failure limit.
Created attachment 253475 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 253472 [details] Patch Attachment 253472 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5548548250664960 Number of test failures exceeded the failure limit.
Created attachment 253477 [details] Archive of layout-test-results from ews106 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 253501 [details] Patch
Comment on attachment 253501 [details] Patch Attachment 253501 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5934523674001408 New failing tests: media/accessiblity-describes-video.html
Created attachment 253503 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 253501 [details] Patch Attachment 253501 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5655257786875904 New failing tests: media/accessiblity-describes-video.html
Created attachment 253504 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 253506 [details] Patch Fixes for iOS, Win, and OS X Mavericks.
Attachment 253506 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/SoftLinking.h:453: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:466: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:471: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:297: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 4 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 253534 [details] Patch
Attachment 253534 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/SoftLinking.h:453: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:464: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:287: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:298: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:303: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 253537 [details] Patch
Attachment 253537 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/SoftLinking.h:453: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:464: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:287: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:298: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:303: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 253537 [details] Patch Attachment 253537 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6116733769220096 New failing tests: media/accessiblity-describes-video.html
Created attachment 253538 [details] Archive of layout-test-results from ews102 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 253537 [details] Patch Attachment 253537 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6557673365438464 New failing tests: media/accessiblity-describes-video.html
Created attachment 253539 [details] Archive of layout-test-results from ews105 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 253563 [details] Patch Tests were failing because I forgot to include the new test media file in the patch. Things should pass the EWS now.
Attachment 253563 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/SoftLinking.h:453: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:464: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:287: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:298: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:303: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 253563 [details] Patch Attachment 253563 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5362614821453824 New failing tests: media/accessiblity-describes-video.html
Created attachment 253569 [details] Archive of layout-test-results from ews103 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 253563 [details] Patch Attachment 253563 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4608644050059264 New failing tests: media/accessiblity-describes-video.html
Created attachment 253571 [details] Archive of layout-test-results from ews104 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Created attachment 253591 [details] Patch Turns out, media selection groups for non-HLS media doesn't really work in Mavericks; skipping the test there.
Comment on attachment 253591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253591&action=review > Source/WebCore/ChangeLog:32 > + * page/CaptionUserPreferences.cpp: > + (WebCore::CaptionUserPreferences::setPreferredAudioCharacteristic): Simple setter. > + (WebCore::CaptionUserPreferences::preferredAudioCharacteristics): Simple getter. > + * page/CaptionUserPreferences.h: > + * page/CaptionUserPreferencesMediaAF.cpp: > + (WebCore::CaptionUserPreferencesMediaAF::~CaptionUserPreferencesMediaAF): Unregister for audio characteristics change notifications. > + (WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges): Register for same. > + (WebCore::CaptionUserPreferencesMediaAF::setPreferredAudioCharacteristic): If in testing mode, pass to superclass; otherwise no-op. > + (WebCore::CaptionUserPreferencesMediaAF::preferredAudioCharacteristics): If in testing mode, pass to superclass; > + otherwise, ask the media accessibility framework. > + * page/CaptionUserPreferencesMediaAF.h: We should probably rename these files in a follow up patch since they aren't caption specific any more. UserMediaAccessibilityPreferences or MediaAccessibilityUserPreferences?
Created attachment 253602 [details] Patch
(In reply to comment #28) > Comment on attachment 253591 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253591&action=review > > > Source/WebCore/ChangeLog:32 > > + * page/CaptionUserPreferences.cpp: > > + (WebCore::CaptionUserPreferences::setPreferredAudioCharacteristic): Simple setter. > > + (WebCore::CaptionUserPreferences::preferredAudioCharacteristics): Simple getter. > > + * page/CaptionUserPreferences.h: > > + * page/CaptionUserPreferencesMediaAF.cpp: > > + (WebCore::CaptionUserPreferencesMediaAF::~CaptionUserPreferencesMediaAF): Unregister for audio characteristics change notifications. > > + (WebCore::CaptionUserPreferencesMediaAF::setInterestedInCaptionPreferenceChanges): Register for same. > > + (WebCore::CaptionUserPreferencesMediaAF::setPreferredAudioCharacteristic): If in testing mode, pass to superclass; otherwise no-op. > > + (WebCore::CaptionUserPreferencesMediaAF::preferredAudioCharacteristics): If in testing mode, pass to superclass; > > + otherwise, ask the media accessibility framework. > > + * page/CaptionUserPreferencesMediaAF.h: > > We should probably rename these files in a follow up patch since they aren't > caption specific any more. UserMediaAccessibilityPreferences or > MediaAccessibilityUserPreferences? Yeah. MediaAccessibilityUserPreferences maybe, otherwise it sounds a bit too much like "preferences for accessibility of user media".
Attachment 253602 [details] did not pass style-queue: ERROR: Source/WebCore/platform/mac/SoftLinking.h:453: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:464: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/mac/SoftLinking.h:469: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:287: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:298: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebCore/platform/win/SoftLinking.h:303: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 6 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 253602 [details] Patch Clearing flags on attachment: 253602 Committed r184799: <http://trac.webkit.org/changeset/184799>
media/accessiblity-describes-video.html is broken on bots: https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Faccessiblity-describes-video.html
Hm; they pass locally. I'll investigate this. The hls/ version of this test seems to be working fine on all bots, so I think it's safe to Skip this test while I figure out what's going on.
OK, marked as flaky in r184817 (it sometimes passes, but usually fails).