Bug 145496

Summary:

Any exit from any JIT due to profiling for an inline cache should force all future compilations to be wary

Product:

WebKit

Reporter:

Filip Pizlo <fpizlo>

Component:

JavaScriptCore

Assignee:

Filip Pizlo <fpizlo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
the patch	ggaren: review+

Description Filip Pizlo 2015-05-30 22:34:46 PDT

Previously we had this thing where the FTL would ignore non-FTL exit sites.  That seemed like a good idea at the time, but there are some pathologies that we found in Speedometer where this isn't so good.  For example we might have an exit from the DFG that happened just after the FTL compilation was enqueued.

Comment 1 Filip Pizlo 2015-05-30 22:36:49 PDT

Created attachment 253972 [details]
the patch

Comment 2 Geoffrey Garen 2015-06-01 13:09:04 PDT

Comment on attachment 253972 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253972&action=review

r=me

Is this a Speedometer speedup?

> Source/JavaScriptCore/ChangeLog:3
> +        Any exit from any JIT due to profiling for an inline cache should force all future compilations to be weary

I think you meant "wary".

Comment 3 Filip Pizlo 2015-06-01 22:41:26 PDT

Landed in http://trac.webkit.org/changeset/185103