Bug 145496

Summary: Any exit from any JIT due to profiling for an inline cache should force all future compilations to be wary
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2015-05-30 22:34:46 PDT
Previously we had this thing where the FTL would ignore non-FTL exit sites. That seemed like a good idea at the time, but there are some pathologies that we found in Speedometer where this isn't so good. For example we might have an exit from the DFG that happened just after the FTL compilation was enqueued.
Attachments
the patch (8.71 KB, patch)
2015-05-30 22:36 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2015-05-30 22:36:49 PDT
Created attachment 253972 [details] the patch
Geoffrey Garen
Comment 2 2015-06-01 13:09:04 PDT
Comment on attachment 253972 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=253972&action=review r=me Is this a Speedometer speedup? > Source/JavaScriptCore/ChangeLog:3 > + Any exit from any JIT due to profiling for an inline cache should force all future compilations to be weary I think you meant "wary".
Filip Pizlo
Comment 3 2015-06-01 22:41:26 PDT
Landed in http://trac.webkit.org/changeset/185103
Note You need to log in before you can comment on or make changes to this bug.