Bug 145441

Summary: Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo
Product: WebKit Reporter: Basile Clement <basile_clement>
Component: New BugsAssignee: Basile Clement <basile_clement>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, ggaren, mark.lam, msaboff
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch fpizlo: review+

Description Basile Clement 2015-05-28 11:00:50 PDT 
Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo
Comment 1 Basile Clement 2015-05-28 11:02:36 PDT 
Created attachment 253850 [details]
Patch
Comment 2 Mark Lam 2015-05-28 11:13:58 PDT 
Comment on attachment 253850 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253850&action=review

> Source/JavaScriptCore/dfg/DFGNode.h:2008
>      {

Did you intend to add an ASSERT(hasTypeLocation()) here?
Comment 3 Basile Clement 2015-05-28 11:20:46 PDT 
(In reply to comment #2)
> Comment on attachment 253850 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253850&action=review
> 
> > Source/JavaScriptCore/dfg/DFGNode.h:2008
> >      {
> 
> Did you intend to add an ASSERT(hasTypeLocation()) here?

Oops, indeed. Updating the patch.
Comment 4 Basile Clement 2015-05-28 11:21:33 PDT 
Created attachment 253852 [details]
Patch
Comment 5 Basile Clement 2015-05-28 12:14:46 PDT 
Committed r184958: <http://trac.webkit.org/changeset/184958>