Bug 145441

Summary:

Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo

Product:

WebKit

Reporter:

Basile Clement <basile_clement>

Component:

New Bugs

Assignee:

Basile Clement <basile_clement>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, ggaren, mark.lam, msaboff

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	fpizlo: review+

Basile Clement

Reported 2015-05-28 11:00:50 PDT

Add debug mode assertions for accessors casting JSC::DFG::Node.m_opInfo

Attachments
Patch (2.83 KB, patch) 2015-05-28 11:02 PDT, Basile Clement	no flags	Details Formatted Diff Diff
Patch (2.90 KB, patch) 2015-05-28 11:21 PDT, Basile Clement	fpizlo: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Basile Clement

Comment 1 2015-05-28 11:02:36 PDT

Mark Lam

Comment 2 2015-05-28 11:13:58 PDT

Comment on attachment 253850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253850&action=review > Source/JavaScriptCore/dfg/DFGNode.h:2008 > { Did you intend to add an ASSERT(hasTypeLocation()) here?

Basile Clement

Comment 3 2015-05-28 11:20:46 PDT

(In reply to comment #2) > Comment on attachment 253850 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253850&action=review > > > Source/JavaScriptCore/dfg/DFGNode.h:2008 > > { > > Did you intend to add an ASSERT(hasTypeLocation()) here? Oops, indeed. Updating the patch.

Basile Clement

Comment 4 2015-05-28 11:21:33 PDT

Basile Clement

Comment 5 2015-05-28 12:14:46 PDT

Note You need to log in before you can comment on or make changes to this bug.