Summary: | Add a feature flag for Media Session API | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Rajca <mrajca> | ||||||
Component: | Media | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Enhancement | CC: | commit-queue, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 145411 | ||||||||
Attachments: |
|
Description
Matt Rajca
2015-05-27 15:03:29 PDT
Created attachment 253812 [details]
Patch
Comment on attachment 253812 [details] Patch Rejecting attachment 253812 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 253812, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 0-ab3c-d52691b4dbfc ... Currently at 184927 = f6b7b50df62afbf7c52561d565c52babeba1343f r184928 = aded627b3edfd124c24cd07442f3b482335c8193 r184929 = cf7682057d11c8bb92c42e12c0daf8794987d459 r184930 = 85a89e91d67ef09a279b49b93cf6665950f257a6 r184931 = 6070fe95deb2e392d1bf08fcc8084b9d5721e943 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/6501075360153600 Created attachment 253848 [details]
Rebased on top of tip-of-tree.
Comment on attachment 253848 [details]
Rebased on top of tip-of-tree.
Re-adding the r+ and cq+ flags since this is the same change as the old one, just rebased on top of ToT.
Comment on attachment 253848 [details] Rebased on top of tip-of-tree. Rejecting attachment 253848 [details] from review queue. mrajca@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 253848 [details] Rebased on top of tip-of-tree. Clearing flags on attachment: 253848 Committed r184956: <http://trac.webkit.org/changeset/184956> All reviewed patches have been landed. Closing bug. |