Bug 145348 – Permanent redirects should have long implicit cache lifetime

• Component: Page Loading
• Status: RESOLVED FIXED

[Antti Koivisto]

301 Permanent Redirect that doesn't specify explicit lifetime should have long implicit lifetime. This matches other browsers. (see HttpResponseHeaders::GetFreshnessLifetime() in http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_headers.cc for example)

[Antti Koivisto]

rdar://problem/20680519

[Antti Koivisto]

Created attachment 253648 [details]
patch

[Build Bot]

Comment on attachment 253648 [details]
patch

Attachment 253648 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5067876985733120

New failing tests:
http/tests/cache/cache-redirections.html

[Build Bot]

Created attachment 253649 [details]
Archive of layout-test-results from ews100 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Antti Koivisto]

Created attachment 253652 [details]
patch

[Sam Weinig]

Comment on attachment 253652 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253652&action=review

> Source/WebCore/ChangeLog:10
> +        301 Moved Permanently response that doesn't specify explicit lifetime should have long implicit lifetime.
> +        This matches other browsers.

Is this something that should be spac'd at some point? Should it be added to https://wiki.whatwg.org/wiki/HTTP?

> Source/WebCore/platform/network/CacheValidation.cpp:128
> +        return hours(365 * 24);

Too bad std::chrono doesn't have std::chromo::years.

[Antti Koivisto]

http://trac.webkit.org/changeset/184837

[Antti Koivisto]

> Is this something that should be spac'd at some point? Should it be added to
> https://wiki.whatwg.org/wiki/HTTP?

Maybe!

> Too bad std::chrono doesn't have std::chromo::years.

I suppose it would be hard to define exactly.