RESOLVED FIXED145348
Permanent redirects should have long implicit cache lifetime 
https://bugs.webkit.org/show_bug.cgi?id=145348
Summary Permanent redirects should have long implicit cache lifetime
Antti Koivisto
Reported 2015-05-23 10:59:56 PDT
301 Permanent Redirect that doesn't specify explicit lifetime should have long implicit lifetime. This matches other browsers. (see HttpResponseHeaders::GetFreshnessLifetime() in http://src.chromium.org/viewvc/chrome/trunk/src/net/http/http_response_headers.cc for example)
Attachments
patch (6.98 KB, patch)
2015-05-23 11:37 PDT, Antti Koivisto 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-mavericks (592.00 KB, application/zip)
2015-05-23 12:26 PDT, Build Bot 		no flags
Details
patch (5.25 KB, patch)
2015-05-23 15:50 PDT, Antti Koivisto 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2015-05-23 11:00:30 PDT
rdar://problem/20680519
Antti Koivisto
Comment 2 2015-05-23 11:37:23 PDT
Created attachment 253648 [details] patch
Build Bot
Comment 3 2015-05-23 12:26:35 PDT
Comment on attachment 253648 [details] patch Attachment 253648 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5067876985733120 New failing tests: http/tests/cache/cache-redirections.html
Build Bot
Comment 4 2015-05-23 12:26:38 PDT
Created attachment 253649 [details] Archive of layout-test-results from ews100 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Antti Koivisto
Comment 5 2015-05-23 15:50:46 PDT
Created attachment 253652 [details] patch
Sam Weinig
Comment 6 2015-05-23 17:33:47 PDT
Comment on attachment 253652 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=253652&action=review > Source/WebCore/ChangeLog:10 > + 301 Moved Permanently response that doesn't specify explicit lifetime should have long implicit lifetime. > + This matches other browsers. Is this something that should be spac'd at some point? Should it be added to https://wiki.whatwg.org/wiki/HTTP? > Source/WebCore/platform/network/CacheValidation.cpp:128 > + return hours(365 * 24); Too bad std::chrono doesn't have std::chromo::years.
Antti Koivisto
Comment 7 2015-05-23 20:16:00 PDT
http://trac.webkit.org/changeset/184837
Antti Koivisto
Comment 8 2015-05-23 20:16:54 PDT
> Is this something that should be spac'd at some point? Should it be added to > https://wiki.whatwg.org/wiki/HTTP? Maybe! > Too bad std::chrono doesn't have std::chromo::years. I suppose it would be hard to define exactly.
Note You need to log in before you can comment on or make changes to this bug.