| Summary: | Rationalize the behavior when timing out touch event dispatch | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | NEW --- | ||||||
| Severity: | Normal | CC: | commit-queue, mkwst, sam, simon.fraser, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2015-05-22 22:01:33 PDT
Created attachment 253636 [details]
Patch
Comment on attachment 253636 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253636&action=review > Source/WebKit2/Shared/WebEvent.h:415 > + bool hasEventDeliveryTimedOut() const { return m_eventDeliveryTimedOut; } > + void eventDeliveryTimedOut() { m_eventDeliveryTimedOut = true; } I've been trying to keep these platform Event objects immutable so far. Is there another design that doesn't force mutability here? (In reply to comment #2) > Comment on attachment 253636 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253636&action=review > > > Source/WebKit2/Shared/WebEvent.h:415 > > + bool hasEventDeliveryTimedOut() const { return m_eventDeliveryTimedOut; } > > + void eventDeliveryTimedOut() { m_eventDeliveryTimedOut = true; } > > I've been trying to keep these platform Event objects immutable so far. Is > there another design that doesn't force mutability here? Sure. I don't have to put that information on the event, it can be an additional structure passed along to the WebProcess. Would that be okay with you? (In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 253636 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=253636&action=review > > > > > Source/WebKit2/Shared/WebEvent.h:415 > > > + bool hasEventDeliveryTimedOut() const { return m_eventDeliveryTimedOut; } > > > + void eventDeliveryTimedOut() { m_eventDeliveryTimedOut = true; } > > > > I've been trying to keep these platform Event objects immutable so far. Is > > there another design that doesn't force mutability here? > > Sure. I don't have to put that information on the event, it can be an > additional structure passed along to the WebProcess. > > Would that be okay with you? Yeah, that sounds great! Comment on attachment 253636 [details]
Patch
It sounds like Sam wants you to make changes to the implementation, so I'll r- this to get it our of the review queue.
|