Bug 145304

Summary: Purge PassRefPtr in WebCore/Modules - 2
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: New BugsAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 144092    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Description Gyuyoung Kim 2015-05-22 02:46:44 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-05-22 02:57:21 PDT 
Created attachment 253587 [details]
Patch
Comment 2 Gyuyoung Kim 2015-05-24 07:01:54 PDT 
Created attachment 253656 [details]
Patch
Comment 3 Darin Adler 2015-05-26 09:36:53 PDT 
Comment on attachment 253656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253656&action=review

> Source/WebCore/Modules/webaudio/PeriodicWave.cpp:56
> +        return WTF::move(waveTable);

I’m surprised this WTF::move was needed. Normally the compiler can optimize these without the explicit call to move.
Comment 4 Gyuyoung Kim 2015-05-27 19:13:15 PDT 
Created attachment 253825 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2015-05-27 19:14:30 PDT 
Comment on attachment 253656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253656&action=review

>> Source/WebCore/Modules/webaudio/PeriodicWave.cpp:56
>> +        return WTF::move(waveTable);
> 
> I’m surprised this WTF::move was needed. Normally the compiler can optimize these without the explicit call to move.

Oh, thanks. It is not necessary in this case.
Comment 6 Gyuyoung Kim 2015-05-27 19:30:16 PDT 
Created attachment 253826 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2015-05-27 21:22:55 PDT 
Comment on attachment 253826 [details]
Patch for landing

Clearing flags on attachment: 253826

Committed r184940: <http://trac.webkit.org/changeset/184940>
Comment 8 WebKit Commit Bot 2015-05-27 21:22:59 PDT 
All reviewed patches have been landed.  Closing bug.