Bug 145290

Summary: CPS rethreading should really get rid of GetLocals
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, basile_clement, benjamin, commit-queue, ggaren, mark.lam, mhahnenb, mmirman, msaboff, nrotem, oliver, saam, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch benjamin: review+

Description Filip Pizlo 2015-05-21 18:45:23 PDT 
This is benign right now because CSE gets rid of redundant GetLocals already.  But, the idea is that CSE should not be mandatory.  CPS rethreading should do it right.
Comment 1 Filip Pizlo 2015-05-21 18:49:38 PDT 
Created attachment 253572 [details]
the patch
Comment 2 WebKit Commit Bot 2015-05-21 18:52:09 PDT 
Attachment 253572 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1055:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2015-05-21 23:33:03 PDT 
Landed in http://trac.webkit.org/changeset/184755