| Summary: | MSVC internal compiler error when compiling TemplateRegistryKey class. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | peavo | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, bfulgham, commit-queue, ggaren | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
peavo
2015-05-21 04:23:52 PDT
Created attachment 253520 [details]
Patch
Comment on attachment 253520 [details]
Patch
Strange. This should call Vector(std::initializer_list<String>), but I don't think it's a big deal to remove the explicit initialization to an empty Vector when that is the default behavior anyway.
(In reply to comment #2) > Comment on attachment 253520 [details] > Patch > > Strange. This should call Vector(std::initializer_list<String>), but I > don't think it's a big deal to remove the explicit initialization to an > empty Vector when that is the default behavior anyway. Yes, I'm also a bit surprised that the WinCairo bot doesn't seem to have a problem, maybe we have slightly different versions of MSVC. Thanks for reviewing :) Comment on attachment 253520 [details] Patch Clearing flags on attachment: 253520 Committed r184717: <http://trac.webkit.org/changeset/184717> All reviewed patches have been landed. Closing bug. You should make sure you are running "Update 4" of Visual Studio. It fixes a number of compiler bugs. It does not show up automatically when you do a "check for updates", you have to go to the MSDN site and locate the download link. :-( (In reply to comment #6) > You should make sure you are running "Update 4" of Visual Studio. It fixes a > number of compiler bugs. It does not show up automatically when you do a > "check for updates", you have to go to the MSDN site and locate the download > link. :-( Ah, ok, thanks :) |