Bug 145257

Summary: Layout Test http/tests/media/media-document-referer.html is flaky
Product: WebKit Reporter: Marcos Chavarría Teijeiro (irc: chavaone) <chavarria1991>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, eric.carlson, jer.noble
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed fix none

Marcos Chavarría Teijeiro (irc: chavaone)
Reported 2015-05-21 04:10:45 PDT
The http/tests/media/media-document-referer.html layout test is flaky on GTK+. It fails sometimes. The diff is the following: --- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/media/media-document-referer-expected.txt +++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/media/media-document-referer-actual.txt @@ -1,5 +1,5 @@ Tests that a media document has correct referer header. -video loaded, referer was correct! OK +TIMEOUT: video failed to load without an error. FAIL END OF TEST
Attachments
proposed fix (1.97 KB, patch)
2015-09-14 22:33 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2015-09-14 22:30:26 PDT
This test started to be (very) flaky on Mac, too. It doesn't seem like there was any specific change, my guess is that it's timing. The test expects that the video will load within a second - that doesn't seem like a reasonable expectation for a regression test, which operate under huge CPU load.
Alexey Proskuryakov
Comment 2 2015-09-14 22:33:33 PDT
Created attachment 261176 [details] proposed fix
WebKit Commit Bot
Comment 3 2015-09-14 23:47:02 PDT
Comment on attachment 261176 [details] proposed fix Clearing flags on attachment: 261176 Committed r189778: <http://trac.webkit.org/changeset/189778>
WebKit Commit Bot
Comment 4 2015-09-14 23:47:08 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2015-09-16 08:49:14 PDT
This fixed it.
Note You need to log in before you can comment on or make changes to this bug.