Bug 145235

Summary:

Web Inspector: Use native Arguments detection instead of using toString

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, jonowells, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

DoNotImportToRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Description Joseph Pecoraro 2015-05-20 18:00:37 PDT

* SUMMARY
Use native Arguments detection instead of using toString.

Technically Object.prototype.toString could be overridden anyways. But I still think it is weird to do a toString check here.

Comment 1 Joseph Pecoraro 2015-05-20 18:14:12 PDT

Created attachment 253485 [details]
[PATCH] Proposed Fix

Comment 2 WebKit Commit Bot 2015-05-20 22:12:14 PDT

Comment on attachment 253485 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 253485

Committed r184697: <http://trac.webkit.org/changeset/184697>

Comment 3 WebKit Commit Bot 2015-05-20 22:12:18 PDT

All reviewed patches have been landed.  Closing bug.