Add option to run_jsc_stress_tests to disable JIT testing

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Michael Saboff]

Currently when testing a build that is compiled without the JIT using run_jsc_stress_tests, it creates test variants for the baseline, DFG and FTL for platforms with the FTL.  This is unnecessary and give false failures.

We should add an option to test interpreter only configurations.

[Michael Saboff]

Created attachment 253479 [details]
Patch

[Mark Lam]

Comment on attachment 253479 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253479&action=review

> Tools/Scripts/run-jsc-stress-tests:787
> +        runAlwaysTriggerCopyPhase

Shouldn’t runAlwaysTriggerCopyPhase be run in the no JIT configuration?

> Tools/Scripts/run-jsc-stress-tests:987
> +    if $jitTests
> +        runMozillaTestLLInt(mode, *extraFiles)

Shouldn’t we be running the “runMozillaTestLLInt” version?

[Michael Saboff]

(In reply to comment #2)
> Comment on attachment 253479 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253479&action=review
> 
> > Tools/Scripts/run-jsc-stress-tests:787
> > +        runAlwaysTriggerCopyPhase
> 
> Shouldn’t runAlwaysTriggerCopyPhase be run in the no JIT configuration?

The "no JIT" will effectively run the same test that ran in the "default" case.

> > Tools/Scripts/run-jsc-stress-tests:987
> > +    if $jitTests
> > +        runMozillaTestLLInt(mode, *extraFiles)
> 
> Shouldn’t we be running the “runMozillaTestLLInt” version?

Ditto.

[Michael Saboff]

Created attachment 253481 [details]
Updated patch that always runs runAlwaysTriggerCopyPhase

[Mark Lam]

Comment on attachment 253481 [details]
Updated patch that always runs runAlwaysTriggerCopyPhase

r=me

[Michael Saboff]

Committed r184683: <http://trac.webkit.org/changeset/184683>