Bug 145226

Summary: Use correct String in WTF API tests
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: Tools / TestsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: ap
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Description Alex Christensen 2015-05-20 15:56:50 PDT 
After much more investigation time than I would like to admit, I found a small and obvious error resulting in us reading from memory we're not supposed to in the API tests.
Comment 1 Alex Christensen 2015-05-20 15:58:34 PDT 
Created attachment 253468 [details]
Patch
Comment 2 Alex Christensen 2015-05-20 16:01:59 PDT 
http://trac.webkit.org/changeset/184668
Comment 3 Alexey Proskuryakov 2015-05-20 19:14:11 PDT 
This patch doesn't seem to change any results, how is that possible?
Comment 4 Alex Christensen 2015-05-21 09:33:06 PDT 
(In reply to comment #3)
> This patch doesn't seem to change any results, how is that possible?
Before this patch, we had a StringView pointing to deallocated data that was almost certainly still there because we had just deallocated it and reallocated a new string with a different length.