WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
145226
Use correct String in WTF API tests
https://bugs.webkit.org/show_bug.cgi?id=145226
Summary
Use correct String in WTF API tests
Alex Christensen
Reported
2015-05-20 15:56:50 PDT
After much more investigation time than I would like to admit, I found a small and obvious error resulting in us reading from memory we're not supposed to in the API tests.
Attachments
Patch
(1.44 KB, patch)
2015-05-20 15:58 PDT
,
Alex Christensen
benjamin
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2015-05-20 15:58:34 PDT
Created
attachment 253468
[details]
Patch
Alex Christensen
Comment 2
2015-05-20 16:01:59 PDT
http://trac.webkit.org/changeset/184668
Alexey Proskuryakov
Comment 3
2015-05-20 19:14:11 PDT
This patch doesn't seem to change any results, how is that possible?
Alex Christensen
Comment 4
2015-05-21 09:33:06 PDT
(In reply to
comment #3
)
> This patch doesn't seem to change any results, how is that possible?
Before this patch, we had a StringView pointing to deallocated data that was almost certainly still there because we had just deallocated it and reallocated a new string with a different length.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug