Bug 145226 - Use correct String in WTF API tests
Summary: Use correct String in WTF API tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-20 15:56 PDT by Alex Christensen
Modified: 2015-05-21 09:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2015-05-20 15:58 PDT, Alex Christensen 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-05-20 15:56:50 PDT 
After much more investigation time than I would like to admit, I found a small and obvious error resulting in us reading from memory we're not supposed to in the API tests.
Comment 1 Alex Christensen 2015-05-20 15:58:34 PDT 
Created attachment 253468 [details]
Patch
Comment 2 Alex Christensen 2015-05-20 16:01:59 PDT 
http://trac.webkit.org/changeset/184668
Comment 3 Alexey Proskuryakov 2015-05-20 19:14:11 PDT 
This patch doesn't seem to change any results, how is that possible?
Comment 4 Alex Christensen 2015-05-21 09:33:06 PDT 
(In reply to comment #3)
> This patch doesn't seem to change any results, how is that possible?
Before this patch, we had a StringView pointing to deallocated data that was almost certainly still there because we had just deallocated it and reallocated a new string with a different length.