Bug 145186

Summary:

Crash under WebCore::invalidateStyleRecursively

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

kling

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	kling: review+

Description Antti Koivisto 2015-05-19 14:39:20 PDT

There are reports about crashes where we run out of stack under invalidateStyleRecursively.

Comment 1 Antti Koivisto 2015-05-19 14:59:10 PDT

Created attachment 253406 [details]
patch

Comment 2 Antti Koivisto 2015-05-19 15:16:43 PDT

rdar://problem/19736838

Comment 3 Andreas Kling 2015-05-19 21:12:32 PDT

Comment on attachment 253406 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253406&action=review

r=me

> Source/WebCore/css/StyleInvalidationAnalysis.cpp:120
> +    Vector<Element*> parentStack;

I'd slap some inline capacity on this Vector.

Comment 4 Antti Koivisto 2015-05-19 22:29:07 PDT

https://trac.webkit.org/r184615