Bug 145181

Summary: Don't show unit (bytes) separately from SI prefixes (K, M, etc...)
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: WebKit WebsiteAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, darin, kling
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 141237    
Attachments:
Description Flags
Cleanup cdumez: review+

Ryosuke Niwa
Reported 2015-05-19 14:00:25 PDT
Always use formatBytes instead of d3.format to format values for consistency and simplicity.
Attachments
Cleanup (8.66 KB, patch)
2015-05-19 14:36 PDT, Ryosuke Niwa 		cdumez: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2015-05-19 14:36:16 PDT
Created attachment 253402 [details] Cleanup
Chris Dumez
Comment 2 2015-05-19 14:38:44 PDT
Comment on attachment 253402 [details] Cleanup rs=me
Ryosuke Niwa
Comment 3 2015-05-19 14:39:51 PDT
Committed r184591: <http://trac.webkit.org/changeset/184591>
Darin Adler
Comment 4 2015-05-19 18:39:43 PDT
Just a side note: I don’t think "K" is an SI suffix. It’s "k".
Darin Adler
Comment 5 2015-05-19 18:39:56 PDT
And I think these are SI prefixes, not suffixes.
Ryosuke Niwa
Comment 6 2015-05-19 19:20:14 PDT
(In reply to comment #5) > And I think these are SI prefixes, not suffixes. Oh oops, you're right. I should fix that...
Note You need to log in before you can comment on or make changes to this bug.