Bug 145181 - Don't show unit (bytes) separately from SI prefixes (K, M, etc...)
Summary: Don't show unit (bytes) separately from SI prefixes (K, M, etc...)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 141237
  Show dependency tree / graph
 
Reported: 2015-05-19 14:00 PDT by Ryosuke Niwa
Modified: 2015-05-19 19:20 PDT (History)
3 users (show)

See Also:

Attachments
Cleanup (8.66 KB, patch)
2015-05-19 14:36 PDT, Ryosuke Niwa 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2015-05-19 14:00:25 PDT 
Always use formatBytes instead of d3.format to format values for consistency and simplicity.
Comment 1 Ryosuke Niwa 2015-05-19 14:36:16 PDT 
Created attachment 253402 [details]
Cleanup
Comment 2 Chris Dumez 2015-05-19 14:38:44 PDT 
Comment on attachment 253402 [details]
Cleanup

rs=me
Comment 3 Ryosuke Niwa 2015-05-19 14:39:51 PDT 
Committed r184591: <http://trac.webkit.org/changeset/184591>
Comment 4 Darin Adler 2015-05-19 18:39:43 PDT 
Just a side note: I don’t think "K" is an SI suffix. It’s "k".
Comment 5 Darin Adler 2015-05-19 18:39:56 PDT 
And I think these are SI prefixes, not suffixes.
Comment 6 Ryosuke Niwa 2015-05-19 19:20:14 PDT 
(In reply to comment #5)
> And I think these are SI prefixes, not suffixes.

Oh oops, you're right. I should fix that...