Bug 145179

Summary:

REGRESSION(183787): JIT is enabled for all builds

Product:

WebKit

Reporter:

Michael Saboff <msaboff>

Component:

JavaScriptCore

Assignee:

Michael Saboff <msaboff>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Keywords:

InRadar

Version:

312.x

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	ggaren: review+

Description Michael Saboff 2015-05-19 13:37:17 PDT

FeatureDefines.xcconfig files to enable the JSC JIT by setting ENABLE_JIT.

There are some cases where we may not want the JIT enabled.  Since wtf/Platform.h properly determines what platform CPU combination should have the JIT enabled.  We can probably just remove ENABLE_JIT from the FeatureDefines.xcconfig files.

Comment 1 Michael Saboff 2015-05-19 13:37:37 PDT

<rdar://problem/21024426>

Comment 2 Michael Saboff 2015-05-19 13:52:21 PDT

Created attachment 253396 [details]
Patch

Comment 3 Geoffrey Garen 2015-05-19 13:53:18 PDT

Comment on attachment 253396 [details]
Patch

r=me

Comment 4 WebKit Commit Bot 2015-05-19 14:03:17 PDT

Attachment 253396 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:11:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 5 Michael Saboff 2015-05-19 14:07:15 PDT

(In reply to comment #4)
> Attachment 253396 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/ChangeLog:11:  You should remove the 'No new tests'
> and either add and list tests, or explain why no new tests were possible. 
> [changelog/nonewtests] [5]
> Total errors found: 1 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I updated the change with the added line:
    Only changed the way build options are initialized.

Comment 6 Michael Saboff 2015-05-19 16:09:48 PDT

Committed r184600: <http://trac.webkit.org/changeset/184600>