Bug 145179 – REGRESSION(183787): JIT is enabled for all builds

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Michael Saboff]

FeatureDefines.xcconfig files to enable the JSC JIT by setting ENABLE_JIT.

There are some cases where we may not want the JIT enabled.  Since wtf/Platform.h properly determines what platform CPU combination should have the JIT enabled.  We can probably just remove ENABLE_JIT from the FeatureDefines.xcconfig files.


[Michael Saboff]

<rdar://problem/21024426>

[Michael Saboff]

Created attachment 253396 [details]
Patch

[Geoffrey Garen]

Comment on attachment 253396 [details]
Patch

r=me

[WebKit Commit Bot]

Attachment 253396 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:11:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

(In reply to comment #4)
> Attachment 253396 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/ChangeLog:11:  You should remove the 'No new tests'
> and either add and list tests, or explain why no new tests were possible. 
> [changelog/nonewtests] [5]
> Total errors found: 1 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

I updated the change with the added line:
    Only changed the way build options are initialized.

[Michael Saboff]

Committed r184600: <http://trac.webkit.org/changeset/184600>