Bug 145173

Summary: Add PLUGIN_ARCHITECTURE(MAC) around WKNVCALayerRenderServerPort in NetscapeBrowserFunc.h
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: Plug-insAssignee: Sungmann Cho <sungmann.cho>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Sungmann Cho 2015-05-19 05:10:29 PDT
WKNVCALayerRenderServerPort in NetscapeBrowserFunc.h is meaningful only for Cocoa platform.
So we need to add PLATFORM(COCOA) around it.
Comment 1 Sungmann Cho 2015-05-19 05:12:21 PDT
Created attachment 253381 [details]
Patch
Comment 2 Anders Carlsson 2015-05-19 08:24:05 PDT
Comment on attachment 253381 [details]
Patch

I think this should be PLUGIN_ARCHITECTURE(MAC) or something like that.
Comment 3 Sungmann Cho 2015-05-19 08:46:20 PDT
Created attachment 253387 [details]
Patch
Comment 4 Sungmann Cho 2015-05-19 08:48:50 PDT
Addressed Anders Carlsson's comment.
Comment 5 Sungmann Cho 2015-05-19 08:51:01 PDT
Created attachment 253388 [details]
Patch
Comment 6 WebKit Commit Bot 2015-05-19 15:10:15 PDT
Comment on attachment 253388 [details]
Patch

Clearing flags on attachment: 253388

Committed r184597: <http://trac.webkit.org/changeset/184597>
Comment 7 WebKit Commit Bot 2015-05-19 15:10:20 PDT
All reviewed patches have been landed.  Closing bug.