Bug 145173

Summary: Add PLUGIN_ARCHITECTURE(MAC) around WKNVCALayerRenderServerPort in NetscapeBrowserFunc.h
Product: WebKit Reporter: Sungmann Cho <sungmann.cho>
Component: Plug-insAssignee: Sungmann Cho <sungmann.cho>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Sungmann Cho
Reported 2015-05-19 05:10:29 PDT
WKNVCALayerRenderServerPort in NetscapeBrowserFunc.h is meaningful only for Cocoa platform. So we need to add PLATFORM(COCOA) around it.
Attachments
Patch (1.41 KB, patch)
2015-05-19 05:12 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Patch (1.27 KB, patch)
2015-05-19 08:46 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Patch (1.43 KB, patch)
2015-05-19 08:51 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2015-05-19 05:12:21 PDT
Created attachment 253381 [details] Patch
Anders Carlsson
Comment 2 2015-05-19 08:24:05 PDT
Comment on attachment 253381 [details] Patch I think this should be PLUGIN_ARCHITECTURE(MAC) or something like that.
Sungmann Cho
Comment 3 2015-05-19 08:46:20 PDT
Created attachment 253387 [details] Patch
Sungmann Cho
Comment 4 2015-05-19 08:48:50 PDT
Addressed Anders Carlsson's comment.
Sungmann Cho
Comment 5 2015-05-19 08:51:01 PDT
Created attachment 253388 [details] Patch
WebKit Commit Bot
Comment 6 2015-05-19 15:10:15 PDT
Comment on attachment 253388 [details] Patch Clearing flags on attachment: 253388 Committed r184597: <http://trac.webkit.org/changeset/184597>
WebKit Commit Bot
Comment 7 2015-05-19 15:10:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.