Bug 145173 - Add PLUGIN_ARCHITECTURE(MAC) around WKNVCALayerRenderServerPort in NetscapeBrowserFunc.h
Summary: Add PLUGIN_ARCHITECTURE(MAC) around WKNVCALayerRenderServerPort in NetscapeBr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sungmann Cho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-19 05:10 PDT by Sungmann Cho
Modified: 2015-05-19 21:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.41 KB, patch)
2015-05-19 05:12 PDT, Sungmann Cho
no flags Details | Formatted Diff | Diff
Patch (1.27 KB, patch)
2015-05-19 08:46 PDT, Sungmann Cho
no flags Details | Formatted Diff | Diff
Patch (1.43 KB, patch)
2015-05-19 08:51 PDT, Sungmann Cho
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sungmann Cho 2015-05-19 05:10:29 PDT
WKNVCALayerRenderServerPort in NetscapeBrowserFunc.h is meaningful only for Cocoa platform.
So we need to add PLATFORM(COCOA) around it.
Comment 1 Sungmann Cho 2015-05-19 05:12:21 PDT
Created attachment 253381 [details]
Patch
Comment 2 Anders Carlsson 2015-05-19 08:24:05 PDT
Comment on attachment 253381 [details]
Patch

I think this should be PLUGIN_ARCHITECTURE(MAC) or something like that.
Comment 3 Sungmann Cho 2015-05-19 08:46:20 PDT
Created attachment 253387 [details]
Patch
Comment 4 Sungmann Cho 2015-05-19 08:48:50 PDT
Addressed Anders Carlsson's comment.
Comment 5 Sungmann Cho 2015-05-19 08:51:01 PDT
Created attachment 253388 [details]
Patch
Comment 6 WebKit Commit Bot 2015-05-19 15:10:15 PDT
Comment on attachment 253388 [details]
Patch

Clearing flags on attachment: 253388

Committed r184597: <http://trac.webkit.org/changeset/184597>
Comment 7 WebKit Commit Bot 2015-05-19 15:10:20 PDT
All reviewed patches have been landed.  Closing bug.