Bug 145158

Summary: WebVideoFullscreenManagerProxy has incorrect OS_VERSION_MIN_REQUIRED conditionals.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jer.noble, jonlee
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: iPhone / iPad   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description Jeremy Jones 2015-05-18 20:50:29 PDT 
WebVideoFullscreenManagerProxy has incorrect OS_VERSION_MIN_REQUIRED conditionals.
Comment 1 Jeremy Jones 2015-05-18 20:52:25 PDT 
Created attachment 253360 [details]
Patch
Comment 2 Jeremy Jones 2015-05-18 20:54:02 PDT 
rdar://problem/20964171
Comment 3 Jon Lee 2015-05-18 23:42:32 PDT 
Comment on attachment 253360 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253360&action=review

> Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:519
> +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000

... so how much better does this work than the old way? Does it specifically improve on slower devices?
Comment 4 Jeremy Jones 2015-05-19 12:08:39 PDT 
(In reply to comment #3)
> Comment on attachment 253360 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=253360&action=review
> 
> > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:519
> > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000
> 
> ... so how much better does this work than the old way? Does it specifically
> improve on slower devices?

It isn't about speed. It is about improving responsiveness while waiting on a fence, and decreasing likelihood of deadlocks between fences.
Comment 5 WebKit Commit Bot 2015-05-19 12:57:00 PDT 
Comment on attachment 253360 [details]
Patch

Clearing flags on attachment: 253360

Committed r184583: <http://trac.webkit.org/changeset/184583>
Comment 6 WebKit Commit Bot 2015-05-19 12:57:04 PDT 
All reviewed patches have been landed.  Closing bug.