RESOLVED FIXED 145158
WebVideoFullscreenManagerProxy has incorrect OS_VERSION_MIN_REQUIRED conditionals. 
https://bugs.webkit.org/show_bug.cgi?id=145158
Summary WebVideoFullscreenManagerProxy has incorrect OS_VERSION_MIN_REQUIRED conditio...
Jeremy Jones
Reported 2015-05-18 20:50:29 PDT
WebVideoFullscreenManagerProxy has incorrect OS_VERSION_MIN_REQUIRED conditionals.
Attachments
Patch (2.07 KB, patch)
2015-05-18 20:52 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2015-05-18 20:52:25 PDT
Created attachment 253360 [details] Patch
Jeremy Jones
Comment 2 2015-05-18 20:54:02 PDT
rdar://problem/20964171
Jon Lee
Comment 3 2015-05-18 23:42:32 PDT
Comment on attachment 253360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253360&action=review > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:519 > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000 ... so how much better does this work than the old way? Does it specifically improve on slower devices?
Jeremy Jones
Comment 4 2015-05-19 12:08:39 PDT
(In reply to comment #3) > Comment on attachment 253360 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=253360&action=review > > > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:519 > > +#if __IPHONE_OS_VERSION_MIN_REQUIRED >= 90000 > > ... so how much better does this work than the old way? Does it specifically > improve on slower devices? It isn't about speed. It is about improving responsiveness while waiting on a fence, and decreasing likelihood of deadlocks between fences.
WebKit Commit Bot
Comment 5 2015-05-19 12:57:00 PDT
Comment on attachment 253360 [details] Patch Clearing flags on attachment: 253360 Committed r184583: <http://trac.webkit.org/changeset/184583>
WebKit Commit Bot
Comment 6 2015-05-19 12:57:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.