Bug 145143

Summary:

Fix the build of universal binary with ARMv7k of JavaScriptCore.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

fpizlo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	ggaren: review+

Description Mark Lam 2015-05-18 14:27:40 PDT

Patch coming.

Comment 1 Mark Lam 2015-05-18 14:29:49 PDT

<rdar://problem/20968297>

Comment 2 Mark Lam 2015-05-18 14:33:32 PDT

Created attachment 253344 [details]
the patch.

Comment 3 Geoffrey Garen 2015-05-18 14:42:11 PDT

Comment on attachment 253344 [details]
the patch.

r=me

Would be nice to include in this comment an explanation of exactly why "if X end" has any meaning whatsoever, since it usually has no meaning.

Comment 4 Mark Lam 2015-05-19 12:33:52 PDT

Thanks for the review.  I added an explanation of why this is needed to the ChangeLog.  I also reversed the order of the armv7k and armv7s if statements in LowLevelInterpreter.asm to have them in alphabetical order.

Landed in r184581: <http://trac.webkit.org/r184581>.