Bug 145094

Summary: Add getElementById to DocumentFragment
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+

Description Sam Weinig 2015-05-15 22:48:44 PDT 
Add getElementById to DocumentFragment
Comment 1 Sam Weinig 2015-05-15 22:55:14 PDT 
Created attachment 253266 [details]
Patch
Comment 2 Sam Weinig 2015-05-16 09:42:56 PDT 
Created attachment 253270 [details]
Patch
Comment 3 Alexey Proskuryakov 2015-05-16 11:14:02 PDT 
Comment on attachment 253270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253270&action=review

> Source/WebCore/dom/DocumentFragment.cpp:97
> +    // Add fast path for ShadowRoot, where we are both a DocumentFragment and a TreeScope.

S/Add// ?

> Source/WebCore/dom/DocumentFragment.cpp:101
> +    // Otherwise, fallback to iterating all of the element descendants.

"Fall back" should be with a space here I think.
Comment 4 Sam Weinig 2015-05-16 11:18:02 PDT 
Committed revision 184435.
Comment 5 Darin Adler 2015-05-16 11:50:03 PDT 
Comment on attachment 253270 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253270&action=review

> Source/WebCore/dom/NonElementParentNode.idl:31
> +    Element getElementById([Default=Undefined,ObjCExplicitAtomicString,RequiresExistingAtomicString] optional DOMString elementId);

Spaces after commas please.