Bug 145094

Summary: Add getElementById to DocumentFragment
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+

Sam Weinig
Reported 2015-05-15 22:48:44 PDT
Add getElementById to DocumentFragment
Attachments
Patch (15.26 KB, patch)
2015-05-15 22:55 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (15.72 KB, patch)
2015-05-16 09:42 PDT, Sam Weinig 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2015-05-15 22:55:14 PDT
Created attachment 253266 [details] Patch
Sam Weinig
Comment 2 2015-05-16 09:42:56 PDT
Created attachment 253270 [details] Patch
Alexey Proskuryakov
Comment 3 2015-05-16 11:14:02 PDT
Comment on attachment 253270 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253270&action=review > Source/WebCore/dom/DocumentFragment.cpp:97 > + // Add fast path for ShadowRoot, where we are both a DocumentFragment and a TreeScope. S/Add// ? > Source/WebCore/dom/DocumentFragment.cpp:101 > + // Otherwise, fallback to iterating all of the element descendants. "Fall back" should be with a space here I think.
Sam Weinig
Comment 4 2015-05-16 11:18:02 PDT
Committed revision 184435.
Darin Adler
Comment 5 2015-05-16 11:50:03 PDT
Comment on attachment 253270 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253270&action=review > Source/WebCore/dom/NonElementParentNode.idl:31 > + Element getElementById([Default=Undefined,ObjCExplicitAtomicString,RequiresExistingAtomicString] optional DOMString elementId); Spaces after commas please.
Note You need to log in before you can comment on or make changes to this bug.