| Summary: | Move HTMLElement's children property to ParentNode | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, cdumez, commit-queue, rniwa | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Sam Weinig
2015-05-15 14:09:10 PDT
Created attachment 253223 [details]
Patch
Attachment 253223 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/ContainerNode.cpp:944: An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Total errors found: 1 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 253223 [details] Patch Attachment 253223 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5261873276518400 New failing tests: js/dom/dom-static-property-for-in-iteration.html Created attachment 253225 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 253223 [details]
Patch
r=me! (with layout test rebaseline)
Comment on attachment 253223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=253223&action=review > Source/WebCore/dom/ContainerNode.cpp:946 > + } else if (type == SelectOptions) { Also the style script is right that we shouldn't use "else" here and below. Comment on attachment 253223 [details] Patch Attachment 253223 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6251226509344768 New failing tests: js/dom/dom-static-property-for-in-iteration.html Created attachment 253229 [details]
Archive of layout-test-results from ews100 for mac-mavericks
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100 Port: mac-mavericks Platform: Mac OS X 10.9.5
Committed revision 184420. |